2015-04-21 8:36 GMT+09:00 Akinobu Mita <akinobu.mita@xxxxxxxxx>:
> Now we can generate correct PI for WRITE SAME command, so it is
> unnecessary to disallow WRITE SAME when protection info is enabled.
I noticed that this patch has multiple problems.
> @@ -381,11 +381,6 @@ fd_execute_write_same(struct se_cmd *cmd)
> target_complete_cmd(cmd, SAM_STAT_GOOD);
> return 0;
> }
> - if (cmd->prot_op) {
> - pr_err("WRITE_SAME: Protection information with FILEIO"
> - " backends not supported\n");
> - return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
> - }
>
> if (cmd->t_data_nents > 1 ||
> cmd->t_data_sg[0].length != cmd->se_dev->dev_attrib.block_size) {
> @@ -401,6 +396,14 @@ fd_execute_write_same(struct se_cmd *cmd)
> if (!bvec)
> return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
>
> + if (cmd->prot_op) {
> + ret = fd_do_rw(cmd, fd_dev->fd_prot_file, se_dev->prot_length,
> + cmd->t_prot_sg, cmd->t_prot_nents,
> + cmd->prot_length, 0);
The last argument should be '1' as this is write. and we need to
perform DIF verify
before writing.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
