On Tue, Apr 21, 2015 at 12:39:40PM +0200, Ondrej Zary wrote: > Thanks, I missed that as it was already wrong before (since at least when > DEF_SCSI_QCMD was introduced). And it worked despite that. If you turn on CONFIG_DEBUG_ATOMIC_SLEEP=y it will generate a warning splat. Otherwise you probably have to get very unlucky for this to deadlock. > > Should I just change that to GFP_ATOMIC? The other option is to do the allocation before taking the lock. That looks do-able. You are the expert here by virtue of you touched to code last. So you get to decide. :) regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
