On 12/30/2014 09:07 AM, Joe Lawrence wrote: > A colleague noticed that the mpt2 and mpt3sas drivers do not correctly > check the PCI master abort pattern in _base_wait_for_doorbell_ack. This > pattern should be checked *prior* to any valid bit patterns, which would > always return true since a PCI read on master abort sets all bits high. > > The second patch adds similar checking to _base_wait_for_doorbell_int and > _base_wait_for_doorbell_not_used to avoid potentially long loops around > PCI reads. > > Joe Lawrence (2): > mpt2sas,mpt3sas: correct master-abort checking in doorbell ack > mpt2sas,mpt3sas: additional master abort checks > > drivers/scsi/mpt2sas/mpt2sas_base.c | 17 ++++++++++++----- > drivers/scsi/mpt3sas/mpt3sas_base.c | 17 ++++++++++++----- > 2 files changed, 24 insertions(+), 10 deletions(-) > Avago ping? This one was pretty straightforward: check 0xFFFFFFFF *before* any individual bit(s), i.e. before reading the doorbell register. -- Joe -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
