On 02/21/15 01:00, Nicholas A. Bellinger wrote: > On Fri, 2015-02-20 at 11:49 +0100, Bart Van Assche wrote: >> What I proposed myself consists of three steps: >> 1. Updating the LIO SRP target driver to a more recent version. >> 2. Target driver and LIO core refactoring such that the LIO and >> SCST APIs can be unified. >> 3. Adding support in SCST for the unified target driver API. >> >> This work is taking a little more time than I had expected - I still >> have to start with step (3). But I can already show in which direction I >> would like to go for steps (1) and (2). The 43 patches I came up with so >> far for steps (1) and (2) are available in the lio branch of the >> https://github.com/bvanassche/linux git repository. As you can see in >> that repository 42 of these 43 patches make sense even without knowing >> that something like SCST exists. > > Please go ahead and post the series for review with bug fixes at the > head of the series, with future improvements following after the fixes. > > Doing a brief review from your tree, I can see there are some useful > fixes, but also there are some patches that have incorrect assumptions > and/or break the existing userspace APIs. > > That said, I'm happy to review the full series, and very much appreciate > your efforts to improve upstream code. > > However, keep in mind that I'll not be merging anything for target-core > that adds support for out-of-tree code, nor anything that changes > existing target configfs APIs to fit out-of-tree code requirements. Let's start with what we agree on and discuss the other topics during the LSF/MM summit. I just sent one patch of that series to the linux-scsi mailing list for review. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
