Re: [PATCH] iscsi-target: use '%*ph' specifier to dump hex buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2015-01-15 at 13:40 +0200, Andy Shevchenko wrote:
> Instead of pushing each byte via stack the %*ph specifier allows to supply just
> a pointer and length of the buffer. The patch converts code to use the
> specifier.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  drivers/target/iscsi/iscsi_target_configfs.c | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/target/iscsi/iscsi_target_configfs.c b/drivers/target/iscsi/iscsi_target_configfs.c
> index 9059c1e..526becd 100644
> --- a/drivers/target/iscsi/iscsi_target_configfs.c
> +++ b/drivers/target/iscsi/iscsi_target_configfs.c
> @@ -674,12 +674,9 @@ static ssize_t lio_target_nacl_show_info(
>  		rb += sprintf(page+rb, "InitiatorAlias: %s\n",
>  			sess->sess_ops->InitiatorAlias);
>  
> -		rb += sprintf(page+rb, "LIO Session ID: %u   "
> -			"ISID: 0x%02x %02x %02x %02x %02x %02x  "
> -			"TSIH: %hu  ", sess->sid,
> -			sess->isid[0], sess->isid[1], sess->isid[2],
> -			sess->isid[3], sess->isid[4], sess->isid[5],
> -			sess->tsih);
> +		rb += sprintf(page+rb,
> +			      "LIO Session ID: %u   ISID: 0x%6ph  TSIH: %hu  ",
> +			      sess->sid, sess->isid, sess->tsih);
>  		rb += sprintf(page+rb, "SessionType: %s\n",
>  				(sess->sess_ops->SessionType) ?
>  				"Discovery" : "Normal");
> @@ -1758,9 +1755,7 @@ static u32 lio_sess_get_initiator_sid(
>  	/*
>  	 * iSCSI Initiator Session Identifier from RFC-3720.
>  	 */
> -	return snprintf(buf, size, "%02x%02x%02x%02x%02x%02x",
> -		sess->isid[0], sess->isid[1], sess->isid[2],
> -		sess->isid[3], sess->isid[4], sess->isid[5]);
> +	return snprintf(buf, size, "%6phN", sess->isid);
>  }
>  
>  static int lio_queue_data_in(struct se_cmd *se_cmd)

Applied to target-pending/for-next.

Thanks Andy!

--nab


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux