On Sun, 2015-01-18 at 16:11 +0100, Christoph Hellwig wrote:
> The midlayer logging already prints the cdb details if the logging
> level is high enough, no need to duplicate this in the ch driver.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> drivers/scsi/ch.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/scsi/ch.c b/drivers/scsi/ch.c
> index 79e462f..0045742 100644
> --- a/drivers/scsi/ch.c
> +++ b/drivers/scsi/ch.c
> @@ -194,18 +194,10 @@ ch_do_scsi(scsi_changer *ch, unsigned char *cmd, int cmd_len,
>
> retry:
> errno = 0;
> - if (debug) {
> - char logbuf[SCSI_LOG_BUFSIZE];
> -
> - __scsi_format_command(logbuf, sizeof(logbuf), cmd, cmd_len);
> - DPRINTK("command: %s", logbuf);
> - }
> -
> result = scsi_execute_req(ch->device, cmd, direction, buffer,
> buflength, &sshdr, timeout * HZ,
> MAX_RETRIES, NULL);
>
> - DPRINTK("result: 0x%x\n",result);
> if (driver_byte(result) & DRIVER_SENSE) {
> if (debug)
> scsi_print_sense_hdr(ch->device, ch->name, &sshdr);
Reviewed-by: Ewan D. Milne <emilne@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
