>-----Original Message----- >From: Christoph Hellwig [mailto:hch@xxxxxx] >Sent: Saturday, January 10, 2015 10:41 PM >To: Sumit.Saxena@xxxxxxxxxxxxx; kashyap.desai@xxxxxxxxxxxxx >Cc: martin.petersen@xxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx >Subject: [PATCH 05/10] megaraid_sas: move endianess conversion into caller >of megasas_get_seq_num > >Converting structure fields in place is always a bad idea, and in this case by >moving it into the only caller we also only have to do a single byte swap as >most fields of this structure are never used. > >Signed-off-by: Christoph Hellwig <hch@xxxxxx> >--- > drivers/scsi/megaraid/megaraid_sas_base.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c >b/drivers/scsi/megaraid/megaraid_sas_base.c >index a6556ea..548d033 100644 >--- a/drivers/scsi/megaraid/megaraid_sas_base.c >+++ b/drivers/scsi/megaraid/megaraid_sas_base.c >@@ -4823,11 +4823,11 @@ megasas_get_seq_num(struct megasas_instance >*instance, > /* > * Copy the data back into callers buffer > */ >- eli->newest_seq_num = le32_to_cpu(el_info- >>newest_seq_num); >- eli->oldest_seq_num = le32_to_cpu(el_info- >>oldest_seq_num); >- eli->clear_seq_num = le32_to_cpu(el_info->clear_seq_num); >- eli->shutdown_seq_num = le32_to_cpu(el_info- >>shutdown_seq_num); >- eli->boot_seq_num = le32_to_cpu(el_info->boot_seq_num); >+ eli->newest_seq_num = el_info->newest_seq_num; >+ eli->oldest_seq_num = el_info->oldest_seq_num; >+ eli->clear_seq_num = el_info->clear_seq_num; >+ eli->shutdown_seq_num = el_info->shutdown_seq_num; >+ eli->boot_seq_num = el_info->boot_seq_num; > } > > pci_free_consistent(instance->pdev, sizeof(struct >megasas_evt_log_info), @@ -4991,7 +4991,7 @@ static int >megasas_start_aen(struct megasas_instance *instance) > class_locale.members.class = MR_EVT_CLASS_DEBUG; > > return megasas_register_aen(instance, >- eli.newest_seq_num + 1, >+ le32_to_cpu(eli.newest_seq_num) + 1, > class_locale.word); > } > Acked-by: Sumit Saxena <sumit.saxena@xxxxxxxxxxxxx> >-- >1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
