> -----Original Message----- > From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi- > owner@xxxxxxxxxxxxxxx] On Behalf Of Hannes Reinecke > Sent: Thursday, January 08, 2015 12:44 AM > To: James Bottomley > Cc: Christoph Hellwig; linux-scsi@xxxxxxxxxxxxxxx; Hannes Reinecke > Subject: [PATCH 9/9] scsi_error: do not display kernel pointer in > message logs > > It is not good practice to display the kernel pointer > in any message logs, and it doesn't display any additional > information. And as we know have block-layer assigned tags > we can use them to differentiate the messages. > So remove any pointer references from the displayed messages. > > Signed-off-by: Hannes Reinecke <hare@xxxxxxx> > --- > drivers/scsi/scsi_error.c | 49 +++++++++++++++++++--------------------- > ------- > 1 file changed, 20 insertions(+), 29 deletions(-) > > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c > index e42fff6..10ffa21 100644 > --- a/drivers/scsi/scsi_error.c > +++ b/drivers/scsi/scsi_error.c > @@ -124,41 +124,37 @@ scmd_eh_abort_handler(struct work_struct *work) ... > SCSI_LOG_ERROR_RECOVERY(3, > scmd_printk(KERN_INFO, scmd, > - "scmd %p eh timeout, " > - "not retrying aborted " > - "command\n", scmd)); > + "eh timeout, not retrying " > + "aborted command\n")); checkpatch allows/encourages keeping strings on one line even when they go past the 80th column. So, I recommend joining those two lines. Reviewed-by: Robert Elliott <elliott@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
