On Mon, Nov 03, 2014 at 01:22:18PM +0530, Kashyap Desai wrote: > I also used below setting in slave_alloc(), so that first Inquiry command > received by driver also has valid Tag in (Non-MQ mode). > sdev->tagged_supported = 1 > Without above setting Inquiry command comes with 0xFF. If I see below code > in scsi_scan.c, it looks like tagged_supported value should be popped by > after actual value reported from Inquiry command. > > if ((sdev->scsi_level >= SCSI_2) && (inq_result[7] & 2) && > !(*bflags & BLIST_NOTQ)) > sdev->tagged_supported = 1; > > Does it means what driver set in slave_alloc is OK to get Inquiry commands > with valid Tag ? > What will happen if Target really does not support Tagged command queue > and driver overwrite it in slave_alloc ? I think the right thing here is to better differenciate between assigning a software tag, and a SCSI tagged command. That is, we should assign a request->tag value for every command if we enable host wide tags, independent of issuing an actual tagged command. I'll send a series of patches for this ASAP. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
