On 09/19/2014 01:58 AM, Elliott, Robert (Server Storage) wrote:
-----Original Message-----
From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx]
...
scmd ties the messages together so you can tell which command
has gotten to which state. grep works.
Can we just print the tag instead, that would be a much more human
readable number normally.
I made a local patch to add the tag (scmd->request->tag), and it does
look good. I endorse dropping scmd %p in favor of just the tag,
and trying to include the tag in all the lines (here, the Done,
Result, CDB, Sense Key, and Add. Sense lines do not)
I would rather use 'scmd->tag', as this should be a straight copy
of scmd->request->tag, but we wouldn't need to reference the request
when doing so.
But yeah, I was planning on doing the same, only I'd rather include
it right a the start like
sd 2:0:0:3 [sdv] tag#1: abort scheduled
and print out a mapping when I/O is submitted
sd 2:0:0:3 [sdv] tag#1: scmd 0xffff880420891470
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxx +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
