On Mon, Sep 01, 2014 at 01:00:26AM +0000, Elliott, Robert (Server Storage) wrote: > > -----Original Message----- > > From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi- > > owner@xxxxxxxxxxxxxxx] On Behalf Of Christoph Hellwig > > Sent: Sunday, 31 August, 2014 5:26 PM > ... > > On Thu, Aug 28, 2014 at 07:33:34PM +0200, Hannes Reinecke wrote: > > > Always use 'scmd 0x%p' when logging a command pointer. > > > > Is there any good reason to print the address of a command pointer? > > It relates the messages to each other. When you get lots of > interleaved messages like: > > [ 3161.441116] sd 2:0:0:2: [sdt] scmd ffff88041a874e70 abort scheduled > [ 3161.444258] sd 2:0:0:2: [sdt] scmd ffff88041a8b3b30 abort scheduled > ... > [ 3162.707427] sd 2:0:0:2: [sdt] aborting command ffff88041a8b3b30 > [ 3162.710445] sd 2:0:0:2: [sdt] scmd ffff88041a8b3b30 abort failed, rtn 8195 > [ 3162.713092] sd 2:0:0:2: [sdt] aborting command ffff88041a8dd530 > [ 3162.715172] sd 2:0:0:2: [sdt] scmd ffff88041a8dd530 abort failed, rtn 8195 > ... > [ 3171.052277] sd 2:0:0:2: [sdt] scsi_eh_2: flush retry cmd: ffff88041a8b3b30 > [ 3171.054910] sd 2:0:0:2: [sdt] scsi_eh_2: flush retry cmd: ffff88041a8dd530 > ... > [ 3203.406218] sd 2:0:0:0: [sdr] scmd ffff88041a8214b0 not aborting, host in recovery > [ 3203.406424] sd 2:0:0:0: [sdr] scmd ffff88041a8474f0 not aborting, host in recovery > > scmd ties the messages together so you can tell which command > has gotten to which state. grep works. Can we just print the tag instead, that would be a much more human readable number normally. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
