> -----Original Message----- > From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] > Sent: Wednesday, August 20, 2014 6:11 PM > To: Kashyap Desai > Cc: Bart Van Assche; linux-scsi@xxxxxxxxxxxxxxx; aacraid@xxxxxxxxxxx; > Elliott@xxxxxx; jbottomley@xxxxxxxxxxxxx; hch@xxxxxxxxxxxxx > Subject: Re: [PATCH] scsi.mq:Added enable_cmd_list flags in hostt to reduce > lock contention > > On Wed, Aug 20, 2014 at 06:08:37PM +0530, Kashyap Desai wrote: > > > This code is in the hot path which means that caching "enable_cmd_list" > > > in struct Scsi_Host (as is done for many other SCSI host parameters) > > > probably will (slightly) improve performance further. Otherwise this > > > patch looks fine to me. > > I will send updated patch which will cache host template field > > "enable_cmd_list" for faster access in Scsi Host. > > Thanks. It might be worth to only set in in the host in fact. Fine. I will remove host template entry and add code in aacraid and dpt_i2o drivers to set that value directly in "Scsi Host" > > Also please just remove the code about lock contention in scsi_mq_prep_fn > - the XXX really doesn't apply anymore and I think the code should be self- > explaining enough to not need a comment. I will do this. > > Otherwise the patch looks good to me. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
