On Wed, Aug 20, 2014 at 06:08:37PM +0530, Kashyap Desai wrote: > > This code is in the hot path which means that caching "enable_cmd_list" > > in struct Scsi_Host (as is done for many other SCSI host parameters) > > probably > > will (slightly) improve performance further. Otherwise this patch looks > > fine to > > me. > I will send updated patch which will cache host template field > "enable_cmd_list" for faster access in Scsi Host. Thanks. It might be worth to only set in in the host in fact. Also please just remove the code about lock contention in scsi_mq_prep_fn - the XXX really doesn't apply anymore and I think the code should be self-explaining enough to not need a comment. Otherwise the patch looks good to me. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
