> -----Original Message----- > From: Hannes Reinecke [mailto:hare@xxxxxxx] > Sent: Monday, July 14, 2014 1:58 AM > To: Christoph Hellwig > Cc: KY Srinivasan; jasowang@xxxxxxxxxx; apw@xxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; ohering@xxxxxxxx; > jbottomley@xxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; > stable@xxxxxxxxxxxxxxx > Subject: Re: [PATCH V3 1/7] Drivers: scsi: storvsc: Change the limits to reflect > the values on the host > > On 07/14/2014 10:30 AM, Christoph Hellwig wrote: > > On Mon, Jul 14, 2014 at 08:15:17AM +0200, Hannes Reinecke wrote: > >> Limiting max_lun to 255 will make the driver to _not_ respond to LUNs > >> higher than that; ie Well-known LUN won't work here. > >> Also the SCSI stack will be using REPORT LUNS anyway since you're > >> advertising SPC-2 compliance. So your driver runs into issues if > >> Hyper-V would ever return more than 256 LUNs with the REPORT LUN > >> command or if any of the LUNs has an addressing scheme other than > >> '0x00'. > >> I would suggest to raise this to the technical limit (ie the largest > >> LUN which the _protocol_ supports) and let REPORT LUNS deal with the > >> actual LUNs. > > > > I suspect hypverv doesn't support anything more. For now I'd be > > inclined to just put it in ASAP and if your suggestion works out fix > > it up later, although I'll wait a bit for more review feedback. > > > Okay, that's fine by me. Christoph, Is this patch-set ready to be checked in. Let me know if you want me to make any further corrections. Regards, K. Y > > Cheers, > > Hannes > -- > Dr. Hannes Reinecke zSeries & Storage > hare@xxxxxxx +49 911 74053 688 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
