On Wed, Jul 16, 2014 at 06:13:21AM -0500, Mike Christie wrote: > I see the request timer is started before calling queue_rq, but I could > not figure out what the cancel_delayed_work here is for exactly. It > seems if the request were to time out and the eh started while queue_rq > was running we could end up some nasty bugs like the requested requeued > twice. > > Is the cancel_delayed_work call just to be safe or is supposed to be > handling a case where the abort_work could be queued at this time up due > to a request timing out while queue_rq is running? Is this case mq specific? It was cargo cult copy & paste from the old path. I've merged a patch from Bart to remove it from the old code, so it should go away here as well, thanks for the reminder. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
