On Sun, Jun 29, 2014 at 08:28:34PM +0200, Tomas Henzl wrote:
> On 06/27/2014 09:38 PM, Maurizio Lombardi wrote:
> >
> >>> diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c
> >>> index 07934b0..a3e5648 100644
> >>> --- a/drivers/scsi/be2iscsi/be_mgmt.c
> >>> +++ b/drivers/scsi/be2iscsi/be_mgmt.c
> >>> @@ -1015,7 +1015,7 @@ int mgmt_set_ip(struct beiscsi_hba *phba,
> >>> if (if_info->dhcp_state) {
> >>> beiscsi_log(phba, KERN_WARNING, BEISCSI_LOG_CONFIG,
> >>> "BG_%d : DHCP Already Enabled\n");
> >>> - return 0;
> >>> + goto exit;
> >> rc should be initialised - so this needs to be added to your patch
> > It is initialized at the beginning of the function, and it must contain zero when the "goto exit" is executed.
>
> Correct, I haven't noticed the initialisation, sorry for the confusion.
Is this a formal review from you?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
