On Wed, Jun 25, 2014 at 04:21:19PM -0400, Douglas Gilbert wrote: > That function used to be called sg_cmd_done() but > another hacker gave it a more reasonable name (?) > but neglected to fix the printk_s. There are other > examples, so now I prefer: > > SCSI_LOG_TIMEOUT(4, sg_printk(KERN_INFO, sdp, > "%s: pack_id=%d, res=0x%x\n", __func__, > srp->header.pack_id, result)); > > > Oh, and we really shouldn't be printing from this context but > it works and I have found it useful in debugging :-) printk from irq context isn't a problem at all. And just send me the one liner to use __func__ againat the core-for-3.17 tree. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html