>>>>> "Christoph" == Christoph Hellwig <hch@xxxxxxxxxxxxx> writes: Christoph> On Sun, Jun 08, 2014 at 11:37:44PM +0100, Ben Hutchings wrote: >> asd_process_ctrl_a_user() attempts to find user settings in flash, >> and if they are missing it prepares a substitute structure containing >> default values for PHY settings. But having done so, it will still >> try to read user settings - from some random address in flash, as the >> local variable 'offs' has not been initialised. >> >> Since asd_common_setup() already sets default PHY settings, there >> seems to be no need to repeat them here, and we can just return 0. >> >> Compile-tested only. If I read this correctly we'll get the link rates initialized but the sas_addr will no longer be populated for each phy_desc. The old code copied the board global sas_addr into dflt_ps before calling asd_process_ctrla_phy_settings(). Whereas asd_common_setup() does not populate the sas_addr. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
