On Sun, Jun 08, 2014 at 11:37:44PM +0100, Ben Hutchings wrote: > asd_process_ctrl_a_user() attempts to find user settings in flash, and > if they are missing it prepares a substitute structure containing > default values for PHY settings. But having done so, it will still > try to read user settings - from some random address in flash, as the > local variable 'offs' has not been initialised. > > Since asd_common_setup() already sets default PHY settings, there > seems to be no need to repeat them here, and we can just return 0. > > Compile-tested only. > > Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> Can I get another review, too please? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
