>>>>> "Christoph" == Christoph Hellwig <hch@xxxxxxxxxxxxx> writes: Christoph> On Wed, May 28, 2014 at 11:28:43PM -0400, Martin K. Petersen wrote: >> Move flags affecting the integrity code out of the bio bi_flags and >> into the block integrity payload. Christoph> It seems like bip is guaranteed to be non-NULL in all callers Christoph> of the getters and setters. Yeah, check removed. Christoph> I'd recommend just dropping them and opencode the flags Christoph> manipulation. The reason I don't use test_bit() and set_bit() is that bip_flags is just a short. And to-shift-or-not-to-shift is a crappy, error prone interface, IMHO. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
