>>>>> "Christoph" == Christoph Hellwig <hch@xxxxxxxxxxxxx> writes: Hey Christoph, >> Add a flag to the block integrity profile that indicates whether the >> disk has been formatted with protection information. Christoph> I'm totally confused on why the sysfs file and flag are named Christoph> 'disk'. What does it stand for given that we already have a Christoph> very established use of the term 'disk' in block I/O land.. The flag indicates whether or not the disk itself is integrity capable. I.e. whether the protection extends beyond the HBA or not. I'm open to suggestions for a better name. When I originally did this I found it hard to come up with something that didn't sound convoluted or redundant. The file resides in /sys/block/foo/integrity/ and I guess I found "disk" sufficient given the context. /sys/block/foo/integrity/disk_is_formatted_with_pi /sys/block/foo/integrity/disk_is_integrity_capable /sys/block/foo/integrity/disk_supports_storing_pi Or would you prefer something other than disk? target? storage_device? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html