Re: [PATCH 1/1] iscsi: kill redundant casts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Switching linux-kernel for linux-scsi mailing list.

On 6/9/14, 2:57 PM, 'Nick Black' via open-iscsi wrote:
Remove two redundant casts from char * to char *.

Signed-off-by: Nick Black <nlb@xxxxxxxxxx>
---
  drivers/scsi/scsi_transport_iscsi.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index 0102a2d..38a1de3 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -3059,7 +3059,7 @@ iscsi_get_chap(struct iscsi_transport *transport, struct nlmsghdr *nlh)
  		evchap->u.get_chap.host_no = ev->u.get_chap.host_no;
  		evchap->u.get_chap.chap_tbl_idx = ev->u.get_chap.chap_tbl_idx;
  		evchap->u.get_chap.num_entries = ev->u.get_chap.num_entries;
-		buf = (char *) ((char *)evchap + sizeof(*evchap));
+		buf = (char *)evchap + sizeof(*evchap);
  		memset(buf, 0, chap_buf_size);

  		err = transport->get_chap(shost, ev->u.get_chap.chap_tbl_idx,
@@ -3463,7 +3463,7 @@ iscsi_get_host_stats(struct iscsi_transport *transport, struct nlmsghdr *nlh)
  		evhost_stats->type = nlh->nlmsg_type;
  		evhost_stats->u.get_host_stats.host_no =
  					ev->u.get_host_stats.host_no;
-		buf = (char *)((char *)evhost_stats + sizeof(*evhost_stats));
+		buf = (char *)evhost_stats + sizeof(*evhost_stats);
  		memset(buf, 0, host_stats_size);

  		err = transport->get_host_stats(shost, buf, host_stats_size);



Looks ok to me.

Acked-by: Mike Christie <michaelc@xxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux