On Tue, Mar 18, 2014 at 11:42:21AM +1100, Finn Thain wrote: > All three NCR5380 core driver implementations share the same NCR5380.h > header file so they need to agree on certain macro definitions. > > The flag bit used by the NDEBUG_MERGING macro in atari_NCR5380 and > sun3_NCR5380 collides with the bit used by NDEBUG_LISTS. > > Moreover, NDEBUG_ABORT appears in NCR5380.c so it should be defined in > NCR5380.h rather than in each of the many drivers using that core. > > An undefined NDEBUG_ABORT macro caused compiler errors and led to dodgy > workarounds in the core driver that can now be removed. > (See commits f566a576bca09de85bf477fc0ab2c8c96405b77b and > 185a7a1cd79b9891e3c17abdb103ba1c98d6ca7a.) > > Move all of the NDEBUG_ABORT, NDEBUG_TAGS and NDEBUG_MERGING macro > definitions into NCR5380.h where all the other NDEBUG macros live. > > Also, incorrect "#ifdef NDEBUG" becomes "#if NDEBUG" to fix the warning: > drivers/scsi/mac_scsi.c: At top level: > drivers/scsi/NCR5380.c:418: warning: 'NCR5380_print' defined but not used > drivers/scsi/NCR5380.c:459: warning: 'NCR5380_print_phase' defined but not used > > The debugging code is now enabled when NDEBUG != 0. > > Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
