On Tue, Mar 18, 2014 at 11:42:20AM +1100, Finn Thain wrote: > All NCR5380 drivers already include the NCR5380.h header. Better to > adopt those macros rather than have three variations on them. > > Moreover, the macros in NCR5380.h are preferable because the atari_NCR5380 > and sun3_NCR5380 versions are inflexible. For example, they can't accomodate > dprintk(NDEBUG_MAIN | NDEBUG_QUEUES, ...) > > Replace the *_PRINTK macros from atari_NCR5380.h and sun3_NCR5380.h with > the equivalent macros from NCR5380.h. > > Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html