On Fri, 2014-05-16 at 18:39 +0100, Ian Abbott wrote: > On 2014-05-16 18:14, James Bottomley wrote: > > On Fri, 2014-05-16 at 16:39 +0100, Ian Abbott wrote: > >> From: Andy Whitcroft <apw@xxxxxxxxxxxxx> > >> > >> Suggested-by: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> > > > > That is my patch, isn't it, just with a slightly modified comment: > > > > http://marc.info/?l=linux-scsi&m=137908428211951 > > I believe so, yes. Looking at Ubuntu's kernel repository, Andy reverted > his original 4 patches and applied your patch instead. I'm not sure > about the other patch (PATCH 2/2) that disables the MAINTENANCE_IN > command. Perhaps that was needed as a consequence of claiming to be > SCSI level SPC-3? Yes, see other email. > > Andy promised to go off and test it and that's where the thread ended. I > > take it the results of the testing was positive? I was expecting him to > > report back on that so KY could ack the patch. > > > > James > > The patch seems to be in Ubuntu Saucy's 3.11 kernel version 3.11.0-12.18 > onwards - see > http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-saucy.git;a=log;h=refs/tags/Ubuntu-3.11.0-12.18 > for the logs. > > Would you like me to resubmit the patch with you as the author? There > isn't a "Signed-off-by:" line for you on this patch at the moment. Is > it okay for me to add one? I'm not really comfortable with the way these patches are being submitted. I really need Andy to justify what's been done and why, then find an upstream acceptable format then for the Microsoft Hyper-V guys to ack them. We need more information than you can infer simply from the patches being in Ubuntu. If Andy's off somewhere, we can wait because this is just simply feature enablement; the bug doesn't show unless you enable trim on hv storvsc. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
