On Fri, 2014-05-16 at 16:39 +0100, Ian Abbott wrote: > From: Andy Whitcroft <apw@xxxxxxxxxxxxx> > > BugLink: http://bugs.launchpad.net/bugs/1234417 This is a pretty low quality bug report; where's the analysis that should be in your patch? The problem is, is it not, that when you turn on trim we now also probe for write same using report opcodes (which is a SAI MAINTENANCE IN commad) and that's causing the boot hang. Firstly, that might be an indicator that the SPC3 route isn't a good one because there might be more hidden nasties like this ... and that goes back to how much testing have you done with the patch I suggested? If it is only a WRITE SAME problem, then the preferred route would be simply to set no_write_same in the template. James > Signed-off-by: Andy Whitcroft <apw@xxxxxxxxxxxxx> > Signed-off-by: Tim Gardner <tim.gardner@xxxxxxxxxxxxx> > --- > Original patch title was "UBUNTU: SAUCE: storvsc -- host takes > MAINTENANCE_IN commands badly elide them". Changed by Ian Abbott > <abbotti@xxxxxxxxx> > --- > drivers/scsi/storvsc_drv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c > index 3903c8a..c1eddd1 100644 > --- a/drivers/scsi/storvsc_drv.c > +++ b/drivers/scsi/storvsc_drv.c > @@ -1539,6 +1539,8 @@ static bool storvsc_scsi_cmd_ok(struct scsi_cmnd *scmnd) > * this. So, don't send it. > */ > case SET_WINDOW: > + /* the host does not handle MAINTENANCE_IN preventing boot.*/ > + case MAINTENANCE_IN: > scmnd->result = ILLEGAL_REQUEST << 16; > allowed = false; > break; -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
