Re: Please help me to review the patch about supporting SATA PM in LIBSAS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2014-04-17 at 11:07 +0800, xiangliang yu wrote:
> hi,
> 
> The patch is support SATA PM device and can  find all devices that is
> attached to PM.

By PM you mean Port Multipilier not Power Management ... we can be
easily confused by the acronym, so I'd spell it out.

It also looks like the patch does a bit more: it adds more fine grained
SATA error handling, so in final form it probably should be three
patches: the EH changes, the PMP additions and the mvsas updates to take
advantage of it.

> Until now, i have tested the identified, hot-plug and IO function and
> result is ok except one mvsas timeout issue.
> i'll continue to debug mvsas issue, but i don't know whether the
> libsas code of the patch is ok.
> So, please help me to review the patch if you feel free. thanks!
> the patch is as below:

Your mail system (this time gmail I think) managed to destroy the patch
by reducing all the tabs to a single space, so while it might be OK, I
can't be sure I'm reading it correctly.  You also have a few generic
spelling mistakes like "falied" instead of "failed".

As part of the error handler rewrite, you disconnect
ata_std_error_handler() can we just remove that function now?

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux