On 02/06/2014 07:43 PM, Christoph Hellwig wrote: > From: Bart Van Assche <bvanassche@xxxxxxx> > > SCSI devices may only be removed by calling scsi_remove_device(). > That function must invoke blk_cleanup_queue() before the final put > of sdev->sdev_gendev. Since blk_cleanup_queue() waits for the > block queue to drain and then tears it down, scsi_request_fn cannot > be active anymore after blk_cleanup_queue() has returned and hence > the get_device()/put_device() pair in scsi_request_fn is unnecessary. > > Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx> > Acked-by: Tejun Heo <tj@xxxxxxxxxx> > Reviewed-by: Mike Christie <michaelc@xxxxxxxxxxx> Acked-by: Hannes Reinecke <hare@xxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html