On 02/06/2014 07:43 PM, Christoph Hellwig wrote: > Many callers won't need this and we can optimize them away. In addition > the handling in the __-prefixed variants was inconsistant to start with. > > Based on an earlier patch from Bart Van Assche. > But this decouples the scsi_device refcount from the number of outstanding commands, right? While I'm sure you've audited all call sites, it's now up to the callers to provide proper reference counting. Shouldn't we document it somewhere? Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html