On Fri, Feb 07, 2014 at 03:35:00AM -0600, Mike Christie wrote: > It seems there is a issue with using the cmd_size to indicate the driver > has its own cmd pool and also using that for scsi mq enabled drivers to > indicate that we want the LLD's struct allocated by blk/scsi mq. > > If a driver sets cmd_size for only the scsi/blk mq purpose, this patch > wants the driver to also setup a cmd pool which I do not think is used > when doing scsi/blk mq. I don't quite understand what you mean. cmd_size means that each scsi_cmnd passed to the driver will have additional per-driver data. For the old path it's implemented by creating a slab cache and storing it in the host template to easily find it, for blk-mq it is used to increase the allocation in the block core as scsi doesn't do it's own allocations in this case. Very different implementation underneath, but same effect for the driver. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html