On 02/05/2014 06:39 AM, Christoph Hellwig wrote: > -static struct scsi_host_cmd_pool *scsi_get_host_cmd_pool(gfp_t gfp_mask) > +static struct scsi_host_cmd_pool * > +scsi_find_host_cmd_pool(struct Scsi_Host *shost) > { > + if (shost->hostt->cmd_size) > + return shost->hostt->cmd_pool; > + if (shost->unchecked_isa_dma) > + return &scsi_cmd_dma_pool; > + return &scsi_cmd_pool; > +} > + It seems there is a issue with using the cmd_size to indicate the driver has its own cmd pool and also using that for scsi mq enabled drivers to indicate that we want the LLD's struct allocated by blk/scsi mq. If a driver sets cmd_size for only the scsi/blk mq purpose, this patch wants the driver to also setup a cmd pool which I do not think is used when doing scsi/blk mq. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html