2014/1/6 Douglas Gilbert <dgilbert@xxxxxxxxxxxx>:
>> @@ -2787,6 +2788,7 @@ module_param_named(opts, scsi_debug_opts, int,
>> S_IRUGO | S_IWUSR);
>> module_param_named(physblk_exp, scsi_debug_physblk_exp, int, S_IRUGO);
>> module_param_named(ptype, scsi_debug_ptype, int, S_IRUGO | S_IWUSR);
>> module_param_named(removable, scsi_debug_removable, bool, S_IRUGO |
>> S_IWUSR);
>> +module_param_named(clustering, scsi_debug_clustering, bool, S_IRUGO);
>
>
> Umm, clustering is writeable, so: S_IRUGO | S_IWUSR
OK, it makes sense to make this parameter writable when we adds
scsi_debug hosts dynamically through 'add_host' driver attribute.
>> module_param_named(scsi_level, scsi_debug_scsi_level, int, S_IRUGO);
>> module_param_named(sector_size, scsi_debug_sector_size, int, S_IRUGO);
>> module_param_named(unmap_alignment, scsi_debug_unmap_alignment, int,
>> S_IRUGO);
>> @@ -3953,6 +3955,8 @@ static int sdebug_driver_probe(struct device * dev)
>> sdbg_host = to_sdebug_host(dev);
>>
>> sdebug_driver_template.can_queue = scsi_debug_max_queue;
>> + if (scsi_debug_clustering)
>> + sdebug_driver_template.use_clustering = ENABLE_CLUSTERING;
>> hpnt = scsi_host_alloc(&sdebug_driver_template,
>> sizeof(sdbg_host));
>> if (NULL == hpnt) {
>> printk(KERN_ERR "%s: scsi_register failed\n", __func__);
>>
>
> And please document this extra parameter for modinfo.
> Something like:
> MODULE_PARM_DESC(clustering, "when set enables larger transfers (def=0)");
>
> placed in alphabetical order.
I'll update this patch and resend it.
Thanks for your review.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
