Re: [PATCH 06/18] target_core_configfs: split up ALUA supported states

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2013-11-19 at 09:07 +0100, Hannes Reinecke wrote:
> Split up the various ALUA states into individual attributes to
> make parsing easier and adhere to the one value per attribute
> sysfs principle.
> 
> Signed-off-by: Hannes Reinecke <hare@xxxxxxx>
> ---

Applied with one minor change below..

>  drivers/target/target_core_configfs.c | 127 ++++++++++++++++++++++------------
>  1 file changed, 84 insertions(+), 43 deletions(-)
> 
> diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
> index 1e4ea28..8476f48 100644
> --- a/drivers/target/target_core_configfs.c
> +++ b/drivers/target/target_core_configfs.c

<SNIP>

> -SE_DEV_ALUA_TG_PT_ATTR(alua_supported_states, S_IRUGO | S_IWUSR);
> +#define SE_DEV_ALUA_SUPPORT_STATE_STORE(_name, _var, _bit)		\
> +static ssize_t target_core_alua_tg_pt_gp_store_attr_alua_support_##_name(\
> +	struct t10_alua_tg_pt_gp *t, const char *p, size_t c)		\
> +{									\
> +	unsigned long tmp;						\
> +	int ret;							\
> +									\
> +	if (!t->tg_pt_gp_valid_id) {					\
> +		pr_err("Unable to do set ##_name ALUA state on non"	\
> +		       " valid tg_pt_gp ID: %hu\n",			\
> +		       t->tg_pt_gp_valid_id);				\
> +		return -EINVAL;						\
> +	}								\
> +									\
> +	ret = strict_strtoul(p, 0, &tmp);				\

Converted to kstrtoul()

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux