On Tue, 2013-11-19 at 09:07 +0100, Hannes Reinecke wrote:
> Signed-off-by: Hannes Reinecke <hare@xxxxxxx>
> ---
Applied, with two minor changes below..
> drivers/target/target_core_configfs.c | 50 +++++++++++++++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
>
> diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
> index 3a964fb..1e4ea28 100644
> --- a/drivers/target/target_core_configfs.c
> +++ b/drivers/target/target_core_configfs.c
> @@ -2131,6 +2131,55 @@ static ssize_t target_core_alua_tg_pt_gp_store_attr_alua_access_type(
> SE_DEV_ALUA_TG_PT_ATTR(alua_access_type, S_IRUGO | S_IWUSR);
>
> /*
> + * alua_supported_states
> + */
> +static ssize_t target_core_alua_tg_pt_gp_show_attr_alua_supported_states(
> + struct t10_alua_tg_pt_gp *tg_pt_gp,
> + char *page)
> +{
> + return sprintf(page, "%02x\n",
> + tg_pt_gp->tg_pt_gp_alua_supported_states);
> +}
> +
> +static ssize_t target_core_alua_tg_pt_gp_store_attr_alua_supported_states(
> + struct t10_alua_tg_pt_gp *tg_pt_gp,
> + const char *page,
> + size_t count)
> +{
> + unsigned long tmp;
> + int new_states, valid_states, ret;
> +
> + if (!tg_pt_gp->tg_pt_gp_valid_id) {
> + pr_err("Unable to do set supported ALUA states on non"
> + " valid tg_pt_gp ID: %hu\n",
> + tg_pt_gp->tg_pt_gp_valid_id);
> + return -EINVAL;
> + }
> +
> + ret = strict_strtoul(page, 0, &tmp);
> + if (ret < 0) {
> + pr_err("Unable to extract new supported ALUA states"
> + " from %s\n", page);
> + return -EINVAL;
> + }
Changed strict_strtoul() -> kstrtoul()
> + new_states = (int)tmp;
> + valid_states = ALUA_T_SUP | ALUA_O_SUP | ALUA_LBD_SUP | \
> + ALUA_U_SUP | ALUA_S_SUP | ALUA_AN_SUP | ALUA_AO_SUP;
> +
Dropping the unnecessary line continuation here..
--nab
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
