Looks reasonable to me, but a few minor nitpicks: > + spin_lock_irqsave(sdev->host->host_lock, flags); > + if (scsi_host_eh_past_deadline(sdev->host)) { I don't have the implementation of scsi_host_eh_past_deadline in my local tree, but do we really need the host lock for it? > +int > +scsi_abort_command(struct scsi_cmnd *scmd) Semms like this should be static and not exported in the current version of the code? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html