>>>>> "James" == James Bottomley <jbottomley@xxxxxxxxxxxxx> writes: James> Once that's done, I think the patch looks like the one below, is James> that OK? Looks OK to me. James> I still have qualms about the media access check because what can James> happen is that we abort, TUR succeeds then the next Media access James> command fails, we abort, TUR succeeds etc until the media access James> timeout goes off. The problem is that it never gets escalated to James> a reset which might fix the condition. All the cases we had in the field involved devices where the command processing part of the device worked fine but the media access became impossible (think wedged read/write head assembly, dead FTL on an SSD). I haven't seen any cases where a device would respond to SPC commands while failing all media accesses and then be able to resume media accesses after a reset. Doesn't mean that such a device doesn't exist, of course, but the patch was originally done to handle the "irreparably broken" error case. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
