Re: [PATCH RESEND] sd: disk offlined prematurely from media access timeout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>>>> "David" == David Jeffery <djeffery@xxxxxxxxxx> writes:

David> There is an error with the medium access timeout feature of the
David> sd driver. The sdkp->medium_access_timed_out value is set to zero
David> in sd_done() in the wrong place.  It is set to zero only if a
David> command returns sense data.  If an I/O command times out, error
David> handling succeeds, and the I/O commands complete, the value won't
David> be reset if nothing responds with a sense buffer.  Then, another
David> timeout (no matter how far in the future) can increment it again,
David> causing the device to be errantly set offline.

David> The resetting of sdkp->medium_access_timed_out should occur
David> before the check for sense data.

David> Signed-off-by: David Jeffery <djeffery@xxxxxxxxxx>

Acked-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux