On Fri, Oct 11, 2013 at 11:52:53AM -0700, Andy Grover wrote: > It seemed better to me to keep the munging from queue_limits values > to what the target core needed in the block backstore code, and not > use a block-specific structure in the backstore<->core interface. > > It looks like a few includes of blkdev.h slipped into target core, > but these can be removed safely -- lio core doesn't depend on the > block layer. > > We could define a new struct to get the 4 values at once, but it > didn't seem worth it, esp. since two are only needed by > emulate_readcapacity16, and the other two only by emulate_evpd_b0. I really don't like the influx of methods. But given thsat you have done the work I'd say merge your patch for now and then we can later see if we can come up with something more elegant. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
