On Wed, Sep 18, 2013 at 09:33:04AM +0200, Gerd Hoffmann wrote: > > > While being at it rename the list head from "list" to "work", preparing > > > for the addition of a second list. > > > > Why do you even the list? > > The list was already there when I took over maintainance ... > > > What would a ordered per-device workqueue not > > provide? > > Had no reason to look into replacing the list with something else so > far. Why do you suggest using a workqueue instead? > > Note that the list is not used in a typical request workflow. Only in > case queuing an usb urb failed the request is linked into the list and > the worker will try to submit the usb urb again. The driver is only using the list to queue up things into workqueue context as far as I can see. Which means it's far easier to leave that to the workqueue. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
