On Di, 2013-09-17 at 13:30 -0700, Christoph Hellwig wrote: > On Fri, Sep 13, 2013 at 01:27:12PM +0200, Gerd Hoffmann wrote: > > Simplifies locking, we'll protect the list with the device spin lock. > > Also plugs races which can happen when two devices operate on the > > global list. > > > > While being at it rename the list head from "list" to "work", preparing > > for the addition of a second list. > > Why do you even the list? The list was already there when I took over maintainance ... > What would a ordered per-device workqueue not > provide? Had no reason to look into replacing the list with something else so far. Why do you suggest using a workqueue instead? Note that the list is not used in a typical request workflow. Only in case queuing an usb urb failed the request is linked into the list and the worker will try to submit the usb urb again. cheers, Gerd -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
