Re: [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, September 24, 2013 3:55 AM, James Bottomley wrote:
> On Mon, 2013-09-23 at 09:54 +0900, Jingoo Han wrote:
> > Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> > (device-core: Ensure drvdata = NULL when no driver is bound),
> > the driver core clears the driver data to NULL after device_release
> > or on probe failure. Thus, it is not needed to manually clear the
> > device driver data to NULL.
> 
> Look, these are particularly pointless patches.  The null setting is
> only on teardown; the fact that we set something to NULL that should
> already be null doesn't matter at all the extra cycles simply won't be
> noticed.  Please roll them into a single patch and send them to Jiří
> Kosina and the trivial tree (cc'd) he'll take care of checking and
> applying them (assuming they meet his criteria for worth bothering
> with).
> 

OK, I see.
I squashed all 20 patches into a single patch, and sent the single patch
to Jiri Kosina and the trivial tree, as you mentioned.
Thank you for your guidance.

Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux