On 07/19/2013 Xinghai Yu <yuxinghai@xxxxxxxxxxxxxx> wrote: > The "sci_phy_link_layer_initialization()" was called only once in > "sci_phy_initialize()" and it is called before a call of "sci_change_state(&iphy- > >sm, SCI_PHY_STOPPED)". So the same call in the end of > "sci_phy_link_layer_initialization()" is redundant. > > Signed-off-by: Xinghai Yu <yuxinghai@xxxxxxxxxxxxxx> > --- > drivers/scsi/isci/phy.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/isci/phy.c b/drivers/scsi/isci/phy.c > index cb87b2e..82e8491 100644 > --- a/drivers/scsi/isci/phy.c > +++ b/drivers/scsi/isci/phy.c > @@ -309,9 +309,6 @@ sci_phy_link_layer_initialization(struct isci_phy *iphy, > */ > writel(0, &llr->link_layer_hang_detection_timeout); > > - /* We can exit the initial state to the stopped state */ > - sci_change_state(&iphy->sm, SCI_PHY_STOPPED); > - > return SCI_SUCCESS; > } > Acked-by: Lukasz Dorau <lukasz.dorau@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
