On 09/11/2013 04:14 PM, Alan Stern wrote: > On Tue, 10 Sep 2013, Oliver Neukum wrote: > >> On Tue, 2013-09-10 at 13:25 -0400, Alan Stern wrote: >>> On Tue, 10 Sep 2013, Oliver Neukum wrote: >>> >>>> Hi Hannes, >>>> >>>> you objected to this patch saying there's a possibilty that >>>> HS devices may also need this feature, which would require >>>> a quirk. Does this mean that the patch is acceptable only >>>> with an additional predefined quirk, or do you insist that all >>>> devices be handled with quirks? >>> >>> Indeed, we already know of one or two high-speed devices that suffer >>> from this bug: >>> >>> http://marc.info/?l=linux-usb&m=133586313307042&w=2 >>> >>> This may influence your decision. I'm not certain whether it is >>> important enough to merit a new quirk flag, but people experiencing the >>> problem may have some strong opinions. >> >> What is the alternative? > > There are three possibilities: nothing, your proposed patch, and a new > quirk flag. The flag is safest, but also the hardest to maintain. > >> I think we can be sure that no drive enclosure will crash >> with READ_CAPACITY_16. > > I wouldn't count on it, but I don't know of any examples. > Me neither. The whole issue just smells of some firmware coders messing up their stuff. So I would think that other firmwares might not have this problem. (But as HS enclosures aren't that common chances are we've hit the same firmware by chance on every test machine we've had.) I think it would warrant a quirk approach. Yes, it might be slightly more coding, but at the same time it's more selective on where it should trigger. Also looking at scsiglue.c it would make things quite tricky if you'd want to _disable_ this feature for HS devices; other firmware from other vendors might not exhibit this issue after all. And scsiglue.c already has tons of quirks set, adding one more doesn't do any harm. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
