On Mon, 2013-09-09 at 13:31 -0700, Hiral Patel wrote:
> This feature gathers active and cumulative per fnic stats for io,
> abort, terminate, reset, vlan discovery path and it also includes
> various important stats for debugging issues. It also provided
> debugfs and ioctl interface for user to retrieve these stats.
> It also provides functionality to reset cumulative stats through
> user interface.
Checkpatch has quite a bit to say about this, but in particular it
doesn't like the instances of
> + if (fnic_stats_debugfs_root) {
> + debugfs_remove(fnic_stats_debugfs_root);
Because debugfs_remove() can be called on a NULL pointer
and
> + ret = strict_strtoul(buf, 10, &val);
> + if (ret < 0)
> + return ret;
Because this should be using kstrtoul(); we're trying to obsolete
strict_strtoul.
Please fix.
Thanks,
James
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
