Tested-by: Maya Erez <merez@xxxxxxxxxxxxxx> > > Looks good. Reviewed-by: Subhash Jadavani <subhashj@xxxxxxxxxxxxxx> > > On 4/24/2013 9:36 PM, Seungwon Jeon wrote: >> Move the ufshcd_hba_stop from header file. >> >> Signed-off-by: Seungwon Jeon <tgih.jun@xxxxxxxxxxx> >> --- >> drivers/scsi/ufs/ufshcd.c | 9 +++++++++ >> drivers/scsi/ufs/ufshcd.h | 9 --------- >> 2 files changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c >> index 60fd40c..41b9639 100644 >> --- a/drivers/scsi/ufs/ufshcd.c >> +++ b/drivers/scsi/ufs/ufshcd.c >> @@ -285,6 +285,15 @@ static inline void ufshcd_hba_start(struct ufs_hba >> *hba) >> } >> >> /** >> + * ufshcd_hba_stop - Send controller to reset state >> + * @hba: per adapter instance >> + */ >> +static inline void ufshcd_hba_stop(struct ufs_hba *hba) >> +{ >> + writel(CONTROLLER_DISABLE, (hba->mmio_base + REG_CONTROLLER_ENABLE)); >> +} >> + >> +/** >> * ufshcd_is_hba_active - Get controller state >> * @hba: per adapter instance >> * >> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h >> index 6b99a42..1680394 100644 >> --- a/drivers/scsi/ufs/ufshcd.h >> +++ b/drivers/scsi/ufs/ufshcd.h >> @@ -190,13 +190,4 @@ int ufshcd_init(struct device *, struct ufs_hba ** >> , void __iomem * , >> unsigned int); >> void ufshcd_remove(struct ufs_hba *); >> >> -/** >> - * ufshcd_hba_stop - Send controller to reset state >> - * @hba: per adapter instance >> - */ >> -static inline void ufshcd_hba_stop(struct ufs_hba *hba) >> -{ >> - writel(CONTROLLER_DISABLE, (hba->mmio_base + REG_CONTROLLER_ENABLE)); >> -} >> - >> #endif /* End of Header */ > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Maya Erez QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html