Re: [PATCH 2/3] scsi_debug: fix NULL pointer dereference with parameters dif=0 dix=1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2013/4/25 Martin K. Petersen <martin.petersen@xxxxxxxxxx>:
>>>>>> "Akinobu" == Akinobu Mita <akinobu.mita@xxxxxxxxx> writes:
>
> Akinobu> The protection info dif_storep is allocated only when parameter
> Akinobu> dif is not zero.  But it will be accessed when reading or
> Akinobu> writing to the storage installed with parameter dix is not
> Akinobu> zero.
>
> Akinobu> So kernel crashes if scsi_debug module is loaded with
> Akinobu> parameters dix=1 and dif=0.
>
> The full story is that scsi_debug does not support DIF and DIX correctly
> by virtue of simultaneously being the HBA and the target. And since
> there is no actual data transfer between the HBA and the target the
> notion of DIF is weak at best.
>
> I did look into making scsi_debug do the right thing but it's quite a
> bit of code and I lost interest about halfway through the effort. If
> you'd like to fix this properly I can probably find the patch to use as
> baseline?

I'm interested in the patch.  So could you provide it?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux