On Tue, Apr 16, 2013 at 12:44 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > We should unlock here before returning. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c > index 9d53540..eb2385f 100644 > --- a/drivers/scsi/megaraid/megaraid_sas_base.c > +++ b/drivers/scsi/megaraid/megaraid_sas_base.c > @@ -4931,11 +4931,12 @@ static int megasas_mgmt_ioctl_fw(struct file *file, unsigned long arg) > printk(KERN_ERR "megaraid_sas: timed out while" > "waiting for HBA to recover\n"); > error = -ENODEV; > - goto out_kfree_ioc; > + goto out_up; > } > spin_unlock_irqrestore(&instance->hba_lock, flags); > > error = megasas_mgmt_fw_ioctl(instance, user_ioc, ioc); > + out_up: > up(&instance->ioctl_sem); > > out_kfree_ioc: > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html Thanks Dan, this looks good. Acked-by: Adam Radford <aradford@xxxxxxxxx> -Adam -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
