Re: [scsi:misc 46/59] drivers/scsi/qla2xxx/qla_mr.c:3007:7: warning: large integer implicitly truncated to unsigned type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[linux-scsi cc added]
On Fri, 2013-04-12 at 09:34 +0800, kbuild test robot wrote:
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc
> head:   9e45dd73234af9a59613dc2989dcc2df2dab847f
> commit: 8ae6d9c7eb1004bc134813287010d57a863ba13b [46/59] [SCSI] qla2xxx: Enhancements to support ISPFx00.
> config: make ARCH=powerpc allmodconfig
> 
> All warnings:
> 
>    drivers/scsi/qla2xxx/qla_mr.c: In function 'qlafx00_build_scsi_iocbs':
> >> drivers/scsi/qla2xxx/qla_mr.c:3007:7: warning: large integer implicitly truncated to unsigned type [-Woverflow]
> >> drivers/scsi/qla2xxx/qla_mr.c:3011:7: warning: large integer implicitly truncated to unsigned type [-Woverflow]
> 
> vim +3007 drivers/scsi/qla2xxx/qla_mr.c
> 
>   3001			return;
>   3002		}
>   3003	
>   3004		/* Set transfer direction */
>   3005		if (cmd->sc_data_direction == DMA_TO_DEVICE) {
>   3006			lcmd_pkt->cntrl_flags =
> > 3007			    __constant_cpu_to_le16(TMF_WRITE_DATA);
>   3008			vha->qla_stats.output_bytes += scsi_bufflen(cmd);
>   3009		} else if (cmd->sc_data_direction == DMA_FROM_DEVICE) {
>   3010			lcmd_pkt->cntrl_flags =
> > 3011			    __constant_cpu_to_le16(TMF_READ_DATA);
>   3012			vha->qla_stats.input_bytes += scsi_bufflen(cmd);
>   3013		}
>   3014	

This is because of this definition in qla_mr.h:

struct cmd_type_7_fx00 {
...
	uint8_t cntrl_flags;

Which means that the assignment produces zero on a BE platform.  That
doesn't look right.  Please fix.

James

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux