Re: [PATCH V3 01/12] pm80xx: fix for memory region free

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2013-03-20 at 10:20 -0700, Anand wrote:
> >From 700bfe79294e9f9e1a5def178af52b13928902a9 Mon Sep 17 00:00:00 2001
> From: Sakthivel K <Sakthivel.SaravananKamalRaju@xxxxxxxx>
> Date: Mon, 4 Feb 2013 12:10:02 +0530
> Subject: [PATCH V3 01/12] pm80xx: fix for memory region free
> 
> All memory regions are allocated based on variables total_len
> and alignment but free was based on element_size.

This patch doesn't compile.  It's giving

ERROR: "pm8001_80xx_dispatch" [drivers/scsi/pm8001/pm8001.ko] undefined!
make[1]: *** [__modpost] Error 1


This is because of this hunk:


> @@ -44,8 +44,16 @@
>  
>  static struct scsi_transport_template *pm8001_stt;
>  
> +/**
> + * chip info structure to identify chip key functionality as
> + * encryption available/not, no of ports, hw specific function ref
> + */
>  static const struct pm8001_chip_info pm8001_chips[] = {
> -	[chip_8001] = {  8, &pm8001_8001_dispatch,},
> +	[chip_8001] = {0,  8, &pm8001_8001_dispatch,},
> +	[chip_8008] = {0,  8, &pm8001_80xx_dispatch,},
> +	[chip_8009] = {1,  8, &pm8001_80xx_dispatch,},
> +	[chip_8018] = {0,  16, &pm8001_80xx_dispatch,},
> +	[chip_8019] = {1,  16, &pm8001_80xx_dispatch,},

But the structure isn't defined until patch 06/12.  This patch series
has to be bisectable and buildable.  That means each individual patch
must apply, compile and run in sequence.  Please fix this.

Thanks,

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux