On Tue, 2013-04-02 at 11:33 +0300, Or Gerlitz wrote: > On 23/03/2013 01:55, Nicholas A. Bellinger wrote: > > +++ b/drivers/infiniband/ulp/isert/isert_core.h > > @@ -0,0 +1,11 @@ > > +#include <linux/socket.h> > > +#include <linux/in.h> > > +#include <linux/in6.h> > > +#include <rdma/ib_verbs.h> > > +#include <rdma/rdma_cm.h> > > + > > +extern void iser_cq_tx_tasklet(unsigned long); > > +extern void isert_cq_tx_callback(struct ib_cq *, void *); > > +extern void iser_cq_rx_tasklet(unsigned long); > > +extern void isert_cq_rx_callback(struct ib_cq *, void *); > > +extern void isert_free_rx_descriptors(struct isert_conn *); > > no need for externs here too, agree? also, any reason for these two > header files not > to be merged into one or into one of the other header files? > <nod>, merging into a single source/include for RFC-v3 code. > > diff --git a/drivers/infiniband/ulp/isert/isert_verbs.h b/drivers/infiniband/ulp/isert/isert_verbs.h > > new file mode 100644 > > index 0000000..da7924d > > --- /dev/null > > +++ b/drivers/infiniband/ulp/isert/isert_verbs.h > > @@ -0,0 +1,5 @@ > > +extern void isert_connect_release(struct isert_conn *); > > +extern void isert_put_conn(struct isert_conn *); > > +extern int isert_cma_handler(struct rdma_cm_id *, struct rdma_cm_event *); > > +extern int isert_post_recv(struct isert_conn *, u32); > > +extern int isert_post_send(struct isert_conn *, struct iser_tx_desc *); > > -- > To unsubscribe from this list: send the line "unsubscribe target-devel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html